I have spend majority of last two years training every day. Here are the few pros and cons of this fitness approach for Forex traders, according to my personal experience.
Daily trek in the forest does not count as training. It is simple movement. Body should be moved every single day. Whatever it is.
You will get in really good shape. Both cardiovascular and strength wise.
It is cool to train every day. It is also cool conversation starter.
You will get tougher. Both mentally and physically.
It is great exercise of discipline. As a result your ability to stay disciplined will grow. That is extremely important for every area of live and especially for FOREX trading.
It will give your days a nice steady rhythm. It will make your overall lifestyle healthier. It will make you get enough sleep and eat good food as default.
You have to pace yourself. If you train everyday, you can't go too hard every day. Balls to the wall training, will leave you depleted for the next session. This leaves you training lackluster, if you want to be smart about it and keep the same steady level of difficulty.
It will leave you depleted and overtrained at times.
The mundane tasks outside the gym will become hard at times due to the muscle fatigue.
The damage to your joints and tissues may be accumulating. It will become easier to injure yourself.
It goes against the fundamental anabolic (rest) / katabolic (exertion)cycle of all living things (jing and jang , give and take).
It will not necessarily improve your performance or help look physically better (fit). If anything it will make your face look more tired.
If your are trying to accomplish anything else other than becoming professional athlete, training every day is a waste of your precious and limited life force.
The primary goal of training should be to make you better, stronger and healthier. Not to wear you out. For that purpose, training 3-4 times a week is perfectly enough (day on, day off). For me personally training every day proved to be suboptimal in all aspects of my endeavours.